From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AABCF1FF163 for <inbox@lore.proxmox.com>; Thu, 7 Nov 2024 16:29:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 718D03339D; Thu, 7 Nov 2024 16:29:34 +0100 (CET) Message-ID: <dd2622c7-f951-4222-a23b-785b8ff9c216@proxmox.com> Date: Thu, 7 Nov 2024 16:29:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20241018115943.813243-1-c.heiss@proxmox.com> From: Aaron Lauterer <a.lauterer@proxmox.com> In-Reply-To: <20241018115943.813243-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer 0/4] auto-install-assistant: allow specifying 'fetch-from' partition label X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> except for two small style nits in comments in patch 4/4 I don't have anything to complain about. Consider this series Tested-By: Aaron Lauterer <a.lauterer@proxmox.com> Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com> On 2024-10-18 13:59, Christoph Heiss wrote: > This series allow specifying the partition label the > `proxmox-fetch-answer` tool will search when trying to retrieve an > answer file in the 'partition' fetch mode. > > This has been requested by at least one user one user [0] and definitely > makes sense, esp. for BMCs/IPMIs where one might not be able to control > the partition label. > > Patch #1 implements the new CLI parameter in the > `proxmox-auto-install-assistant` tool, patch #4 then integrates it into > the `proxmox-fetch-answer` itself. Patch #2 is just a small (but needed) > refactor of the CLI parsing code. > > Patch #3 implements also searching for the partition label in the exact > case it was specified by the user. This is something I stumbled over > while testing it - see the patch itself for some more information. > > [0] https://forum.proxmox.com/threads/proxmox-ais-question-request.153043/post-695689 > > Christoph Heiss (4): > auto-install-assistant: add new parameter to specify partition label > fetch-answer: refactor cli argument parsing > fetch-answer: partition: also search for exact-matching partition > label > fetch-answer: use partition label from fetch config instead of > hardcoded > > proxmox-auto-install-assistant/src/main.rs | 13 ++++- > proxmox-auto-installer/src/utils.rs | 1 + > .../src/fetch_plugins/partition.rs | 29 ++++++---- > proxmox-fetch-answer/src/main.rs | 58 ++++++++++++++----- > 4 files changed, 76 insertions(+), 25 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel