From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 947F4914F for ; Thu, 24 Aug 2023 14:45:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7D24832668 for ; Thu, 24 Aug 2023 14:45:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 24 Aug 2023 14:45:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 585C043BFB for ; Thu, 24 Aug 2023 14:45:37 +0200 (CEST) Message-ID: Date: Thu, 24 Aug 2023 14:45:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 To: Proxmox VE development discussion , Filip Schauer References: <20230823105839.36751-1-f.schauer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20230823105839.36751-1-f.schauer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.270 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.684 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] Fix ACPI-suspended VMs resuming after migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2023 12:45:38 -0000 Am 23.08.23 um 12:58 schrieb Filip Schauer: > When migrating a VM that suspended itself via ACPI, it will no longer be > resumed automatically. > > Signed-off-by: Filip Schauer At a first glance, it seems like the other callers of vm_is_paused() could also benefit from treating the 'suspended' runstate the same way as 'paused'. Can you please check that and instead add the check for 'suspended' directly to the vm_is_paused() function? If you can come up with a good name it might make sense to rename the function too, or at least add a comment saying that the "paused" does not mean only the runstate 'paused' but includes other runstates where the VM is paused ;) And we might want to treat the runstate 'prelaunch' as paused too. There's also runstates for being paused during certain phases of migration, but maybe we can ignore them for now. Shouldn't be strictly required, because of our config locking. Full list would be here: https://qemu.readthedocs.io/en/v8.0.0/interop/qemu-qmp-ref.html#qapidoc-85