From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E6BB41FF15D for ; Thu, 25 Jul 2024 18:22:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34E749335; Thu, 25 Jul 2024 18:22:22 +0200 (CEST) Message-ID: Date: Thu, 25 Jul 2024 18:21:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Dietmar Maurer References: <20240724113329.175907-1-dietmar@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <20240724113329.175907-1-dietmar@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-xtermjs v3] termproxy: allow to use unix sockets for auth requests X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 24/07/2024 13:33, Dietmar Maurer wrote: > Remove ureq, because it does not support unix sockets. > > Signed-off-by: Dietmar Maurer > --- > > Changes sinve v2: > split out the command line help text change into patch: > [PATCH pve-xtermjs] termproxy: fix the command line help text > > Changes since v1: > > - use extra --authsocket cli option FYI: I renamed this and the pre-existing --authport option to --auth-socket and --auth-port, respectively, with the latter getting a fallback to the old variant for backward compat. And yeah I know that this in borderline useless as it's just an internal tool, but I got a few spare minutes in the train where starting something more involved was not justified, and making this consistent with the `--port-as-fd` option and our modern CLI option style in general felt like an OK clean-up to do. Anyhow, now bumped and uploaded as proxmox-termproxy in version 1.1.0. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel