From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 427FC1FF137
	for <inbox@lore.proxmox.com>; Tue, 03 Feb 2026 16:09:27 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 87CB822BEA;
	Tue,  3 Feb 2026 16:09:56 +0100 (CET)
Message-ID: <dcccab1f-1a75-42d8-9436-e08dcca36fce@proxmox.com>
Date: Tue, 3 Feb 2026 16:09:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH qemu-server 1/2] tests: improve multiarch build support
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260203142209.3614946-1-d.csapak@proxmox.com>
 <ee782cc6-5e62-4d56-91bc-e9fe57af2916@proxmox.com>
 <96b3810e-bb32-4045-bbeb-f5aa4c82d3f4@proxmox.com>
Content-Language: en-US
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <96b3810e-bb32-4045-bbeb-f5aa4c82d3f4@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1770131317147
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -0.020 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: YVWJUBFDHC3BO5AG2VYSGTO6WH4JLI2Z
X-Message-ID-Hash: YVWJUBFDHC3BO5AG2VYSGTO6WH4JLI2Z
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 03.02.26 um 16:03 schrieb Dominik Csapak:
> 
> alternatively, we could write out 'PVE::Tools::get_host_arch' everywhere
> without importing, then we'd only have to mock once
> (but makes the code slightly less readable)

could combine that with adding a local helper with the same name though.
While I prefer having no extra code for testing, it's not always possible
and a simple getter would be at least save to have.