From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C66A71FF170 for ; Thu, 15 May 2025 10:41:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44F451D1C4; Thu, 15 May 2025 10:41:52 +0200 (CEST) Message-ID: Date: Thu, 15 May 2025 10:41:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20250513105652.67403-1-f.ebner@proxmox.com> <20250513105652.67403-3-f.ebner@proxmox.com> <885a462e-aa47-46c6-97dd-647b1c7dc9ed@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <885a462e-aa47-46c6-97dd-647b1c7dc9ed@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [service.in] Subject: Re: [pve-devel] [PATCH pve-lxc-syscalld 2/4] service: avoid using generic runtime directory name X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 14.05.25 um 16:33 schrieb Thomas Lamprecht: > Am 13.05.25 um 12:56 schrieb Fiona Ebner: >> When the service is restarted, the directory will be recreated. The >> issue is that the /run/pve directory is not just used as the runtime >> directory of this service, but also for other things, e.g. storage >> tunnel and mtunnel sockets and container stderr logs as well as pull >> metrics, which will be lost when the service is restarted. > > Is there much gained by moving the socket path or would it be enough to > drop the RundtimeDirectory completely or do we want to rely on the > clean-up being done by systemd? Which probably is an OK enough reason, > I'd think.. Yes, the cleanup aspect is there and it seems nicer to have a dedicated directory IMHO. It would avoid the need to adapt pve-container and the postinst snippet, but I'd still like to go for the "dedicated RuntimeDirectory" approach. > btw., to name all options, there would be the RuntimeDirectoryPreserve= > property for systemd services (documented in man systemd.exec) which > we could set to `restart` to handle just updates or `yes` to never clean > it up; besides obviously a system reboot clearing any tmpfs, that is. That option would not help with the awkward dependency/reliance on the service to create the /run/pve directory in the first place. And even if it's created by the tmpfiles.d snippet in pve-manager first, it will get overwritten (with root:root 0755 permissions) when its first used as the service's runtime directory. >> >> Signed-off-by: Fiona Ebner >> --- >> >> Versioned breaks for pve-container and pve-manager needed. >> >> etc/pve-lxc-syscalld.service.in | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/etc/pve-lxc-syscalld.service.in b/etc/pve-lxc-syscalld.service.in >> index be076a7..0557fe6 100644 >> --- a/etc/pve-lxc-syscalld.service.in >> +++ b/etc/pve-lxc-syscalld.service.in >> @@ -4,8 +4,8 @@ Before=pve-guests.service >> >> [Service] >> Type=notify >> -ExecStart=%LIBEXECDIR%/pve-lxc-syscalld/pve-lxc-syscalld --system /run/pve/lxc-syscalld.sock >> -RuntimeDirectory=pve >> +ExecStart=%LIBEXECDIR%/pve-lxc-syscalld/pve-lxc-syscalld --system /run/pve-lxc-syscalld/lxc-syscalld.sock > > If we go for a dedicated directory we could drop the redundancy in the > file name, e.g. > > /run/pve-lxc-syscalld/sock > > or > > /run/pve-lxc-syscalld/socket Okay, I'll go for the latter in v2. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel