From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 477C11FF133
	for <inbox@lore.proxmox.com>; Mon, 11 May 2026 19:03:26 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 265B121BEB;
	Mon, 11 May 2026 19:03:26 +0200 (CEST)
Message-ID: <dc9edbd0-26b7-42eb-aa60-7d8e7aee6eab@proxmox.com>
Date: Mon, 11 May 2026 19:03:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH pve-network v4 18/31] fabrics: wireguard: add schema
 definitions for wireguard
To: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
References: <20260507124008.417223-1-s.hanreich@proxmox.com>
 <20260507124008.417223-19-s.hanreich@proxmox.com>
 <jwhhycluimjkplvehtgzqw4jkxmkvcfvkr6ql76y3oenfg73z2@yv24imp4t4ox>
Content-Language: en-US
From: Stefan Hanreich <s.hanreich@proxmox.com>
In-Reply-To: <jwhhycluimjkplvehtgzqw4jkxmkvcfvkr6ql76y3oenfg73z2@yv24imp4t4ox>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.622 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: HBELY4ORHUIK4DYCIWRXOPXYAP2UR7XL
X-Message-ID-Hash: HBELY4ORHUIK4DYCIWRXOPXYAP2UR7XL
X-MailFrom: s.hanreich@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 5/11/26 3:36 PM, Arthur Bied-Charreton wrote:
> On Thu, May 07, 2026 at 02:39:53PM +0200, Stefan Hanreich wrote:

[snip]

>> @@ -202,18 +239,118 @@ sub node_properties {
>>                      description => 'OSPF network interface',
>>                      optional => 1,
>>                  },
>> +                {
>> +                    type => 'array',
>> +                    'instance-types' => ['wireguard'],
>> +                    items => {
>> +                        description =>
>> +                            "Type of configuration entry in an SDN Fabric section config",

-> updated this description as well

>> +                        type => 'string',
>> +                        format => 'pve-sdn-fabric-wireguard-interface',
>> +                    },
>> +                    description => 'WireGuard network interface',
>> +                    optional => 1,
>> +                },
>>              ],
>>          },
>> -    };
>> -
>> -    if ($update) {
>> -        $properties->{delete} = {
>> +        public_key => {
>> +            'type-property' => 'protocol',
>> +            'instance-types' => ['wireguard'],
>> +            description => 'The role of this node in the WireGuard fabric.',
>> +            type => 'string',
>> +            optional => 1,
>> +        },
> The description does not match the key here

indeed, updated the description - thanks!