From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A5B311FF13F for ; Thu, 12 Mar 2026 09:34:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 55FDE8940; Thu, 12 Mar 2026 09:34:21 +0100 (CET) Message-ID: Date: Thu, 12 Mar 2026 09:33:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-ve-rs v5 2/8] frr: add proxmox-frr-templates package that contains templates To: Gabriel Goller , pve-devel@lists.proxmox.com References: <20260310120705.150425-1-g.goller@proxmox.com> <20260310120705.150425-3-g.goller@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260310120705.150425-3-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773304392017 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Y4S3XCXCKDTNXSSQAPUU2GQMLXKTCQQ7 X-Message-ID-Hash: Y4S3XCXCKDTNXSSQAPUU2GQMLXKTCQQ7 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-10 13:09, Gabriel Goller wrote: > This debian package contains the jinja template files used to generate > the frr config. Currently only the fabrics template files are here, the > rest will be added in later commits. When installing this package the > templates will be installed to `/usr/share/proxmox-frr/templates/`. > `proxmox-frr` will then use `include_str!` to embed the templates into > the binary. > > This package will only be published to the `devel` channel. > > Co-authored-by: Stefan Hanreich > Signed-off-by: Gabriel Goller > --- > Makefile | 8 +++ > proxmox-frr-templates/.gitignore | 1 + > proxmox-frr-templates/Makefile | 50 +++++++++++++++++++ > proxmox-frr-templates/debian/changelog | 5 ++ > proxmox-frr-templates/debian/control | 17 +++++++ > proxmox-frr-templates/debian/copyright | 18 +++++++ > .../debian/proxmox-frr-templates.install | 1 + > proxmox-frr-templates/debian/rules | 5 ++ > .../templates/access_list.jinja | 6 +++ ^ I hope I didn't miss anything, but it doesn't look like this one is used anywhere > .../templates/access_lists.jinja | 6 +++ > proxmox-frr-templates/templates/fabricd.jinja | 29 +++++++++++ > .../templates/frr.conf.jinja | 5 ++ > .../templates/interface.jinja | 9 ++++ > proxmox-frr-templates/templates/ospfd.jinja | 18 +++++++ > .../templates/protocol_routemaps.jinja | 10 ++++ > .../templates/route_maps.jinja | 20 ++++++++ > 16 files changed, 208 insertions(+) > create mode 100644 proxmox-frr-templates/.gitignore > create mode 100644 proxmox-frr-templates/Makefile > create mode 100644 proxmox-frr-templates/debian/changelog > create mode 100644 proxmox-frr-templates/debian/control > create mode 100644 proxmox-frr-templates/debian/copyright > create mode 100644 proxmox-frr-templates/debian/proxmox-frr-templates.install > create mode 100755 proxmox-frr-templates/debian/rules > create mode 100644 proxmox-frr-templates/templates/access_list.jinja > create mode 100644 proxmox-frr-templates/templates/access_lists.jinja > create mode 100644 proxmox-frr-templates/templates/fabricd.jinja > create mode 100644 proxmox-frr-templates/templates/frr.conf.jinja > create mode 100644 proxmox-frr-templates/templates/interface.jinja > create mode 100644 proxmox-frr-templates/templates/ospfd.jinja > create mode 100644 proxmox-frr-templates/templates/protocol_routemaps.jinja > create mode 100644 proxmox-frr-templates/templates/route_maps.jinja [..]