From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2327576FFD for ; Thu, 21 Oct 2021 11:34:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 145B81BA35 for ; Thu, 21 Oct 2021 11:34:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 735D91BA19 for ; Thu, 21 Oct 2021 11:34:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2C8FF458F9 for ; Thu, 21 Oct 2021 11:34:53 +0200 (CEST) To: Proxmox VE development discussion , Thomas Lamprecht References: <20211021083609.2057094-1-t.lamprecht@proxmox.com> From: Stefan Reiter Message-ID: Date: Thu, 21 Oct 2021 11:34:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20211021083609.2057094-1-t.lamprecht@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.636 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.267 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH 0/4] add meta info and bandaid for QEMU 6.1 and unpinned q35 machine backward compat X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2021 09:34:54 -0000 On 10/21/21 10:36 AM, Thomas Lamprecht wrote: > First add a new meta property that is currently exclusively set on new > VM creation and then read-only, initially add the creation time as UNIX > epoch and the QEMU version that was installed during installation > (thought about using the one on first start but that actually does not > gives any more guarantee, so just go for simple). > > Use that information to band aid around a change regarding hotplug in > QEMU 6.1 that can affected older VMs on fresh start (migration and > rollback is covered by force-machine mechanisms as always already). > > I'm not 100% convinced of the whole thing, albeit I see some merit in > the meta property even if we do not go with the last patch, anyhow, I > proposed this off-list to Dominik (and those thing is partly his idea > too), Wolfgang, Fabian and Stefan and none of them rejected the idea nor > communicated a better/more preferred alternative, so I went for it > (still not steaming from enthusiasm though) So we're doing all of this to avoid issues with older VMs that expect "acpi-pci-hotplug-with-bridge-support=off" on Q35 (previously default), but we still want to set it for new VMs that are created with QEMU 6.1 and never booted with anything older. But taking a step back, do we actually want the new ACPI hotplug in general? If we choose to simply leave it be, we could just always add "acpi-pci-hotplug-with-bridge-support=off" to Q35 on QEMU > 6.1. Since it's a global property, I think we wouldn't even need to check machine-type/forcemachine at all, since we'd only make the default explicit with older ones. > > Thomas Lamprecht (4): > config: add new meta property withe creation time > config: meta: also save the QEMU version installed during creation > tests: cfg2cmd: add a few q35 related tests > cfg2cmd: switch off ACPI hotplug on bridges for q35 VMs > > PVE/API2/Qemu.pm | 2 + > PVE/QemuServer.pm | 62 +++++++++++++++++++ > .../q35-linux-hostpci-multifunction.conf.cmd | 1 + > test/cfg2cmd/q35-linux-hostpci.conf.cmd | 1 + > test/cfg2cmd/q35-simple-6.0.conf | 13 ++++ > test/cfg2cmd/q35-simple-6.0.conf.cmd | 28 +++++++++ > test/cfg2cmd/q35-simple-6.1.conf | 14 +++++ > test/cfg2cmd/q35-simple-6.1.conf.cmd | 28 +++++++++ > test/cfg2cmd/q35-simple-pinned-6.1.conf | 13 ++++ > test/cfg2cmd/q35-simple-pinned-6.1.conf.cmd | 28 +++++++++ > test/cfg2cmd/q35-simple.conf | 13 ++++ > test/cfg2cmd/q35-simple.conf.cmd | 29 +++++++++ > test/cfg2cmd/q35-win10-hostpci.conf.cmd | 1 + > 13 files changed, 233 insertions(+) > create mode 100644 test/cfg2cmd/q35-simple-6.0.conf > create mode 100644 test/cfg2cmd/q35-simple-6.0.conf.cmd > create mode 100644 test/cfg2cmd/q35-simple-6.1.conf > create mode 100644 test/cfg2cmd/q35-simple-6.1.conf.cmd > create mode 100644 test/cfg2cmd/q35-simple-pinned-6.1.conf > create mode 100644 test/cfg2cmd/q35-simple-pinned-6.1.conf.cmd > create mode 100644 test/cfg2cmd/q35-simple.conf > create mode 100644 test/cfg2cmd/q35-simple.conf.cmd >