From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 801E41FF16B for <inbox@lore.proxmox.com>; Thu, 6 Mar 2025 16:24:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3D86EA6A9; Thu, 6 Mar 2025 16:23:59 +0100 (CET) Message-ID: <db594331-b46a-4403-96e5-d7bbb1512844@proxmox.com> Date: Thu, 6 Mar 2025 16:23:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20250208054209.598307-1-thomas@atskinner.net> <20250208054209.598307-6-thomas@atskinner.net> Content-Language: en-US From: Mira Limbeck <m.limbeck@proxmox.com> In-Reply-To: <20250208054209.598307-6-thomas@atskinner.net> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.304 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH perl-rs v3 1/1] fix #4234: openid: adjust openid verification function for userinfo option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 2/8/25 06:42, Thomas Skinner wrote: > Signed-off-by: Thomas Skinner <thomas@atskinner.net> > --- > pve-rs/src/openid/mod.rs | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/pve-rs/src/openid/mod.rs b/pve-rs/src/openid/mod.rs > index 1fa7572..8f914ad 100644 > --- a/pve-rs/src/openid/mod.rs > +++ b/pve-rs/src/openid/mod.rs > @@ -54,9 +54,14 @@ mod export { > #[try_from_ref] this: &OpenId, > code: &str, > private_auth_state: PrivateAuthState, > + disable_userinfo: Option<bool>, > ) -> Result<Value, Error> { > let open_id = this.inner.lock().unwrap(); > - let claims = open_id.verify_authorization_code_simple(code, &private_auth_state)?; > + let claims = open_id.verify_authorization_code_simple_userinfo( > + code, > + &private_auth_state, > + disable_userinfo.unwrap_or(false), > + )?; > > Ok(to_value(&claims)?) > } Commit 9ee9ad4 moved the code to common/src/oidc. I had to apply those manually at the new location, and update the forwarding call in pve-rs/src/openid/mod.rs. Other than that, worked as espected. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel