From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 3C5ED7A071
 for <pve-devel@lists.proxmox.com>; Thu,  6 May 2021 14:18:03 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 33DAC205B2
 for <pve-devel@lists.proxmox.com>; Thu,  6 May 2021 14:17:33 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id C23B7205A3
 for <pve-devel@lists.proxmox.com>; Thu,  6 May 2021 14:17:32 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9C72B464F9
 for <pve-devel@lists.proxmox.com>; Thu,  6 May 2021 14:17:32 +0200 (CEST)
Message-ID: <db294c54-94c0-2443-ea4a-5617b91f1000@proxmox.com>
Date: Thu, 6 May 2021 14:17:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101
 Thunderbird/89.0
Content-Language: en-US
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Oguz Bektas <o.bektas@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Lorenz Stechauner <l.stechauner@proxmox.com>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20210506091010.40737-1-l.stechauner@proxmox.com>
 <20210506091105.40976-1-l.stechauner@proxmox.com>
 <20210506091105.40976-2-l.stechauner@proxmox.com>
 <20210506100443.GA12590@gaia.proxmox.com>
 <e11298a3-8355-b48e-4788-9c6de04a125e@proxmox.com>
In-Reply-To: <e11298a3-8355-b48e-4788-9c6de04a125e@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.007 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH v4 common 2/7] tools: add
 download_file_from_url
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 06 May 2021 12:18:03 -0000

On 06.05.21 14:15, Thomas Lamprecht wrote:
> sub check_file_hash
>    my ($algorithm, $expected, $file) = @_;
> 
>    my $algorithm_map = {
>       'sha256' => sub { Digest::SHA->new(512) },

argh, naturally above should use 256, but you get the idea ;-)

>       'sha512' => sub { Digest::SHA->new(512) },
>       # etc...
>    };
> 
>    my $digester = $algorithm_map->{$algorithm}->() or die "unknown algorithm '$algorithm'\n";
> 
>    open(my $fh, '<', $filename) or die "cannot open file '$file': $!\n";
> 
>    my $got = $digester->addfile($fh)->hexdigest;
>    close($fh);
> 
>    return lc($digest) eq lc($expected);
> }