From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D52707232B for ; Thu, 1 Jul 2021 12:57:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C374F23B32 for ; Thu, 1 Jul 2021 12:57:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A960423B21 for ; Thu, 1 Jul 2021 12:57:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 763C142B85 for ; Thu, 1 Jul 2021 12:57:50 +0200 (CEST) Message-ID: Date: Thu, 1 Jul 2021 12:57:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Stefan Reiter References: <20210701093729.2537908-1-s.reiter@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210701093729.2537908-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.559 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server] live-restore: preload efidisk before starting VM X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jul 2021 10:57:51 -0000 On 01.07.21 11:37, Stefan Reiter wrote: > The efidisk never got restored correctly before, since we don't use the > generic print_drive_commandline_full for it, and as such it didn't get a > backing image attached. This not only causes the efidisk data to be lost > on restore, but also an error at the end, since we try to remove a > non-existing PBS blockdev. > > Since it is attached differently to a regular drive, adding PBS backing > would be more difficult, but not to worry: an efidisk is small enough > that it doesn't hurt performance to just restore it via the regular > mechanism before starting the VM, and simply excluding it from the live > restore entirely. > > Signed-off-by: Stefan Reiter > --- > > best viewed with -w > > I guess in QEMU < 6.0 this didn't cause an error, since I definitely tested with > EFI VMs before, however, it would have never actually restored the data and > instead always created a new one. could still be good to backport, I'd figure? > > PVE/QemuServer.pm | 46 ++++++++++++++++++++++++---------------------- > 1 file changed, 24 insertions(+), 22 deletions(-) > > applied, thanks!