From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B591075463 for ; Wed, 21 Apr 2021 16:20:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A5FB7107D3 for ; Wed, 21 Apr 2021 16:20:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2D3BD107C5 for ; Wed, 21 Apr 2021 16:20:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E672844D34; Wed, 21 Apr 2021 16:20:45 +0200 (CEST) Message-ID: Date: Wed, 21 Apr 2021 16:20:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210420081523.2704-1-d.csapak@proxmox.com> From: Thomas Lamprecht Cc: Alwin Antreich In-Reply-To: <20210420081523.2704-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pools.pm, tools.pm, pveceph.pm] Subject: [pve-devel] applied-series: [PATCH manager v4 0/9] ceph: allow pools settings to be changed X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 14:20:46 -0000 On 20.04.21 10:15, Dominik Csapak wrote: > originally from Alwin Antreich > > mostly rebase on master, a few eslint fixes (squashed into alwins > commits) and 3 small fixups > > Alwin Antreich (6): > ceph: add autoscale_status to api calls > ceph: gui: add autoscale & flatten pool view > ceph: set allowed minimal pg_num down to 1 > ceph: gui: rework pool input panel > ceph: gui: add min num of PG > fix: ceph: always set pool size first > > Dominik Csapak (3): > API2/Ceph/Pools: remove unnecessary boolean conversion > ui: ceph/Pools: improve number checking for target_size > ui: ceph/Pool: show progress on pool edit/create > > PVE/API2/Ceph/Pools.pm | 97 +++++++-- > PVE/CLI/pveceph.pm | 4 + > PVE/Ceph/Tools.pm | 61 ++++-- > www/manager6/ceph/Pool.js | 401 +++++++++++++++++++++++++++----------- > 4 files changed, 422 insertions(+), 141 deletions(-) > applied, thanks to both of you! Made some followups on-top, besides some minor code style stuff it was mostly: * avoid horizontal scrolling due to column width for 720p screens * make min_size auto calculation (size + 1) / 2, so that size 4 gets min_size 3 * use the pveSizeField (adapted from the pveBandwidthField) for target size to avoid the *1024*1024*1024 for and back conversion in the panel get/setValues * print pool settings as they're applied, makes a slightly nicer task log.