From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CC52A1FF390 for ; Fri, 10 May 2024 15:28:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B21521E522; Fri, 10 May 2024 15:28:58 +0200 (CEST) Message-ID: Date: Fri, 10 May 2024 15:28:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht , Proxmox VE development discussion References: <20240508124112.2519552-1-d.csapak@proxmox.com> <20240508124112.2519552-3-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [esxiplugin.pm] Subject: Re: [pve-devel] [PATCH storage 1/1] esxi: improve error handling for fuse mount tool X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 5/8/24 16:43, Thomas Lamprecht wrote: > On 08/05/2024 14:41, Dominik Csapak wrote: >> if the fuse tool encounters an error early, it prints it like: >> Error: some error message >> on stderr. >> >> We can capture that here by redirecting STDERR to $wr and die'ing with > > using just a variable name like $wr without context in a commit message > is hardly telling or useful, maybe replace above and the paragraph below > with something like: > > "Redirect the STDERR of the child process that mounts the ESXi instance to > the pipe of the parent (API) process, so that it can pass a hopefully more > meaningful message to the user than just an erroneous return code." > > You're right, that sounds better >> the error message. >> >> With this we die with the original error message instead of only >> with the return code which is telling the user nothing and does not >> help us debug. >> >> Signed-off-by: Dominik Csapak >> --- >> src/PVE/Storage/ESXiPlugin.pm | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm >> index b8bce0e..8dc33fc 100644 >> --- a/src/PVE/Storage/ESXiPlugin.pm >> +++ b/src/PVE/Storage/ESXiPlugin.pm >> @@ -222,6 +222,10 @@ sub esxi_mount : prototype($$$;$) { >> // die "failed to get file descriptor flags: $!\n"; >> fcntl($wr, F_SETFD, $flags & ~FD_CLOEXEC) >> // die "failed to remove CLOEXEC flag from fd: $!\n"; >> + >> + # capture errors from stderr > > nit: you capture all that gets printed to stderr, not just errors, and no > hard feelings, but the comment feels a tiny bit superfluous, at least with > the error message. true, i'll remove the comment > >> + open(STDERR, ">&", \*$wr) or die "unable to redirect STDERR: $!\n"; > > Don't the \ reference operator and the * dereference operator here cancel > each other out? yes, of course, i'll remove those > >> + >> # FIXME: use the user/group options! >> exec {$ESXI_FUSE_TOOL} >> $ESXI_FUSE_TOOL, >> @@ -245,7 +249,7 @@ sub esxi_mount : prototype($$$;$) { >> undef $wr; >> >> my $result = do { local $/ = undef; <$rd> }; >> - if ($result =~ /^ERROR: (.*)$/) { >> + if ($result =~ /^ERROR: (.*)$/i) { >> die "$1\n"; >> } >> > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel