From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7322E60B2A for ; Fri, 9 Oct 2020 18:08:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 62A6617C57 for ; Fri, 9 Oct 2020 18:07:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B391A17C47 for ; Fri, 9 Oct 2020 18:07:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 786BA45CCC for ; Fri, 9 Oct 2020 18:07:47 +0200 (CEST) To: Proxmox VE development discussion , Stoiko Ivanov References: <20201009151344.8999-1-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Fri, 9 Oct 2020 18:07:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201009151344.8999-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.138 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfsplugin.pm, proxmox.com] Subject: [pve-devel] applied: [PATCH storage] ZFSPlugin: untaint lun number X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 16:08:19 -0000 On 09.10.20 17:13, Stoiko Ivanov wrote: > ZFS over iSCSI fetches information about the disk-images via ssh, thus > the obtainted data is tainted (perlsec (1)). > > Since pvedaemon runs with '-T' enabled trying to start a VM via GUI/API failed, > while it still worked via `qm` or `pvesh`. > > The issue surfaced after commit cb9db10c1a9855cf40ff13e81f9dd97d6a9b2698 in > pve-common ('run_command: improve performance for logging and long lines'), > and results from concatenating the original (tainted) buffer to a variable, > instead of a captured subgroup. > > Untainting the value in ZFSPlugin should not cause any regressiosn, since the > other 3 target providers already have a match on '\d+' for retrieving the > lun number. > > reported via pve-user [0]. > > reproduced and tested by setting up a LIO-target (on top of a virtual PVE), > adding it as storage and trying to start a guest (with a disk on the > ZFS over iSCSI storage) with `perl -T /usr/sbin/qm start $vmid` > > [0] https://lists.proxmox.com/pipermail/pve-user/2020-October/172055.html > > Signed-off-by: Stoiko Ivanov > --- > PVE/Storage/ZFSPlugin.pm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > applied, thanks!