From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id AF66E1FF163
	for <inbox@lore.proxmox.com>; Thu,  7 Nov 2024 11:36:15 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 6BFC91E2F1;
	Thu,  7 Nov 2024 11:36:25 +0100 (CET)
Message-ID: <d92e4078-00bf-48ad-9be8-afaeaf7398be@proxmox.com>
Date: Thu, 7 Nov 2024 11:35:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Maximiliano Sandoval <m.sandoval@proxmox.com>
References: <20240913081352.76932-1-m.sandoval@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <20240913081352.76932-1-m.sandoval@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.037 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH storage v4 1/2] fix #5267: storage: add
 bzip2 support
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Does what it says. Tested in combination with the adjacent UI patch [0].


[0] 
https://lore.proxmox.com/pve-devel/20240802143736.172810-1-m.sandoval@proxmox.com/

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On  2024-09-13  10:13, Maximiliano Sandoval wrote:
> A popular ISO compressed exclusively with bz2 is OPNsense [2].
> 
> Since this requires adding `bz2` to the list of known compression
> formats we add decompression methods for vmz and tar.
> 
> [2] https://opnsense.org/download/
> 
> Suggested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> Differences from v3:
>   - Remove gzip dependency from d/control
>   - Fix typo in commit message
>   - Add bz2 to VZTMPL_EXT_RE_1 regex which allow us to:
>   - Fix tests
> 
> Differences from v2:
>   - Fix typo s/lzpo/lzop
>   - Add fix to commit message
> 
> Differences from v1:
>   - Add more context to commit message
>   - Add decompression utilities as explicit dependencies
> 
>   src/PVE/Storage.pm                 |  5 ++++-
>   src/PVE/Storage/Plugin.pm          |  2 +-
>   src/test/archive_info_test.pm      |  6 ++++--
>   src/test/list_volumes_test.pm      | 20 ++++++++++++++++++--
>   src/test/parse_volname_test.pm     | 14 +++++++-------
>   src/test/path_to_volume_id_test.pm | 26 ++++++++++++++++----------
>   6 files changed, 50 insertions(+), 23 deletions(-)
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel