From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E4DF19249F for ; Tue, 14 Mar 2023 11:37:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CE5A41F2CB for ; Tue, 14 Mar 2023 11:37:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 14 Mar 2023 11:37:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 00514447DE for ; Tue, 14 Mar 2023 11:37:01 +0100 (CET) Message-ID: Date: Tue, 14 Mar 2023 11:37:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Dominik Csapak References: <20230306142335.3858041-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230306142335.3858041-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager 0/7] backup edit window improvements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2023 10:37:01 -0000 Am 06/03/2023 um 15:23 schrieb Dominik Csapak: > two bugfixes (the VMSelector changes are necessary for those) > and a refactor of the edit window (i put that patch at the end, because even > with simplifications, it's still ~30 lines more, and i was not sure if that's > worth it) > > Dominik Csapak (7): > ui: VMSelector: columns customizable > ui: VMSelector: improve {set,get}Value handling with a loading store > ui: VMSelector: change from filter to load parameters > ui: VMSelector: correctly change invalid class on en/disable > fix #4490: ui: add column filters in Backup Job edit window > fix #4239: ui: show selected but non-existing vmids in backup edit > ui: BackupEdit: refactor edit window into declarative style > > www/manager6/dc/Backup.js | 788 +++++++++++++++----------------- > www/manager6/form/VMSelector.js | 75 ++- > 2 files changed, 423 insertions(+), 440 deletions(-) > applied series, albeit I wanted to look a bit more closely onto it but my finger slipped, anyhow, the core idea is good and any regression we can fix, so thanks!