From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 457A51FF17C for <inbox@lore.proxmox.com>; Wed, 2 Apr 2025 15:45:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8CF091BDE5; Wed, 2 Apr 2025 15:45:35 +0200 (CEST) Message-ID: <d82f82f8-4789-4ce2-af81-ba697fd4fc4c@proxmox.com> Date: Wed, 2 Apr 2025 15:45:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com> References: <20250304115803.194820-1-m.frank@proxmox.com> Content-Language: en-US From: Daniel Kral <d.kral@proxmox.com> In-Reply-To: <20250304115803.194820-1-m.frank@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v14 0/12] virtiofs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 3/4/25 12:57, Markus Frank wrote: > Virtio-fs is a shared file system that enables sharing a directory > between host and guest VMs. It takes advantage of the locality of > virtual machines and the hypervisor to get a higher throughput than > the 9p remote file system protocol. > > build-order: > 1. cluster > 2. guest-common > 3. docs > 4. qemu-server > 5. manager > > I did not get virtiofsd to run with run_command without creating > zombie processes after stutdown. So I replaced run_command with exec > for now. Maybe someone can find out why this happens. > > > changes in v14: > * disallow commas and equal signs in path until the path can be quoted > in property strings > * addressed style nits and improved formatting > * use max_virtiofs() in check_vm_create_dir_perm > * removed unnecessary checks after parse_property_string > * find_on_current_node returns only one entry > * improved docs > * added missing imports/uses > > changes in v13: > * removed acl/xattr attributes in node config > * renamed acl/xattr in virtiofs qemu config to expose-acl/expose-xattr > * renamed submounts in node config to announce-submounts > * the "disable snapshot (with RAM) and hibernate with virtio-fs devices" > patch now uses the check_non_migratable_resources function > * rewritten the part about announce-submounts in pve-docs patch > > Changes in v12: > * rebase to master as most patches could not be applied anymore > > Changes in v11: > * made submounts option on by default in WebUI and section config > * PVE::QemuServer::Virtiofs dependency removed in QemuServer/Memory.pm > * Minor changes to function/variable names > * Disable snapshots (with RAM) and hibernate due to incompatibility Tested this series with three different guests: - Debian 12.7 + Debian 12.10 (Kernel 6.1 series) - Windows 11 Build 22631 - Fedora 32 (Kernel 5.6 series) Picked the last because it's quite an old kernel and not debian-based. Specific error cases on linux guests (for both Debian and Fedora): - trying to snapshot VM with RAM with virtiofs -> results in error before snapshot of VM with RAM can be done - trying to hibernate VM with virtiofs -> results in error before VM would be hibernated xattr + POSIX ACLs: - trying to `getfacl` on a file with POSIX ACLs set without `expose-xattr` nor `expose-acl` results in just the file mode permissions being printed - trying to `getfacl` on a file with POSIX ACLs set with `expose-xattr` and `expose-acl` results in the POSIX ACLs also printed - Fedora's kernel was probably too old to allow exposing the POSIX ACLs and resulted in a "Connection refused" if expose-acl was enabled (on the host syslog: Cannot enable posix ACLs, client does not support it) Windows-specific error cases: - starting a windows VM with POSIX ACLs enabled prints the warning correctly; also cannot be mounted inside the windows vm just as the docs say - mounting a virtiofs mountpoint inside a windows vm with posix acls disabled works fine; for that matter, if solely xattr is enabled, it works as expected too Everything works as expected here, thanks for the work on this! Also tested this feature with multiple guests accessing the same shared file system "at the same time", i.e. just me working as a user on multiple files + writing to different files at the same time with `dd`. I had some minor nits throughout the series, but else consider this series as: Tested-by: Daniel Kral <d.kral@proxmox.com> Reviewed-by: Daniel Kral <d.kral@proxmox.com> _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel