From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A0D54797EC for ; Wed, 27 Oct 2021 11:56:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 88E5A1092F for ; Wed, 27 Oct 2021 11:55:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D7FB310921 for ; Wed, 27 Oct 2021 11:55:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 84D324351C for ; Wed, 27 Oct 2021 11:55:53 +0200 (CEST) Message-ID: Date: Wed, 27 Oct 2021 11:55:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak , Lorenz Stechauner References: <20211021124919.87618-1-l.stechauner@proxmox.com> <6e865af1-9a82-4ca6-c0b8-2c32141bf4e9@proxmox.com> From: Thomas Lamprecht In-Reply-To: <6e865af1-9a82-4ca6-c0b8-2c32141bf4e9@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.288 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.215 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v3 storage 1/2] fix #3633: pvesm: use print_api_result X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 09:56:24 -0000 On 25/10/2021 16:17, Dominik Csapak wrote: > both patches LGTM, commit message could have used some more info > (like which fields were added, etc.) but no big problem yeah, mentioning that instead of three or so selected columns all are now dumped and some reasoning for doing that (after all #3633 did not asked for that) would be good ;) Would be nice to reduce that a bit for the default output, ideally the content list would made dependent of the content type passed, as `used`, `vmid`, `parent`, `encrypted` and `verification` do not make much sense for `--content vztmpl`. The headers are now all the internal property, `used_fraction` does not read to nicely for a CLI tool human readable output IMO (would be naturally Ok for the machine readable JSON one). There's also ctime in content list that isn't printed more human friendly, which would be the point of #3633, And we really need to reverse the default for (no)border, as the content list for vztmpl on the same storage here produced 72 lines previously (easily fitting on one console page here) and now spews out 145 lines (which needs scrolling), without adding really any value and making copying not exactly easier, but at least that part isn't the job of this patch series. > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak thanks, it works as in breaks not something, but cannot say as advertised as it does quite a bit more than the report requested, which can be fine but would need some commit message to state at least some reasoning or thoughts on it. I'm open to take it in now with at least the columns being the same as previously, fancy auto-column selection and the border stuff can be done later/independent of this.