From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E7357906E0 for ; Fri, 3 Feb 2023 14:56:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C7B1E5733 for ; Fri, 3 Feb 2023 14:56:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 3 Feb 2023 14:56:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EF3F9452C8; Fri, 3 Feb 2023 14:56:41 +0100 (CET) Message-ID: Date: Fri, 3 Feb 2023 14:56:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Proxmox VE development discussion , Alexandre Derumier References: <20230202110344.840195-1-aderumier@odiso.com> <20230202110344.840195-4-aderumier@odiso.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20230202110344.840195-4-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v3 qemu-server 03/13] qemu_memory_hotplug: remove unused $opt arg X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2023 13:56:42 -0000 Am 02.02.23 um 12:03 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 4 ++-- > PVE/QemuServer/Memory.pm | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index e4d1a70..a0e16dc 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -5046,7 +5046,7 @@ sub vmconfig_hotplug_pending { > vmconfig_delete_or_detach_drive($vmid, $storecfg, $conf, $opt, $force); > } elsif ($opt =~ m/^memory$/) { > die "skip\n" if !$hotplug_features->{memory}; > - PVE::QemuServer::Memory::qemu_memory_hotplug($vmid, $conf, $defaults, $opt); > + PVE::QemuServer::Memory::qemu_memory_hotplug($vmid, $conf, $defaults); > } elsif ($opt eq 'cpuunits') { > $cgroup->change_cpu_shares(undef); > } elsif ($opt eq 'cpulimit') { > @@ -5121,7 +5121,7 @@ sub vmconfig_hotplug_pending { > $vmid, $opt, $value, $arch, $machine_type); > } elsif ($opt =~ m/^memory$/) { #dimms > die "skip\n" if !$hotplug_features->{memory}; > - $value = PVE::QemuServer::Memory::qemu_memory_hotplug($vmid, $conf, $defaults, $opt, $value); > + $value = PVE::QemuServer::Memory::qemu_memory_hotplug($vmid, $conf, $defaults, $value); > } elsif ($opt eq 'cpuunits') { > my $new_cpuunits = PVE::CGroup::clamp_cpu_shares($conf->{pending}->{$opt}); #clamp > $cgroup->change_cpu_shares($new_cpuunits); > diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm > index 5a7c1b7..6bb931e 100644 > --- a/PVE/QemuServer/Memory.pm > +++ b/PVE/QemuServer/Memory.pm > @@ -155,7 +155,7 @@ sub foreach_reverse_dimm { > } > > sub qemu_memory_hotplug { > - my ($vmid, $conf, $defaults, $opt, $value) = @_; > + my ($vmid, $conf, $defaults, $value) = @_; > > return $value if !PVE::QemuServer::check_running($vmid); > applied this one, thanks!