From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BD19896984 for ; Tue, 16 Apr 2024 12:54:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9606518241 for ; Tue, 16 Apr 2024 12:53:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 16 Apr 2024 12:53:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8C75245595; Tue, 16 Apr 2024 12:53:37 +0200 (CEST) Message-ID: From: Folke Gleumes To: Proxmox VE development discussion Cc: Daniel Krambrock Date: Tue, 16 Apr 2024 12:53:36 +0200 In-Reply-To: References: X-Priority: 1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 access-control] fix #5335: stable sorting in user.cfg X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2024 10:54:08 -0000 Hi, thanks for your contribution! Looks fine to me. The saving function itself already sorts everything else, so this should be the last point where it can be indeterministic. While at it, could you update the foreach to a for? Not all code already agrees with our style guide, but we try to update it whenever we are touching it [0]. If you haven't done so already, you need to agree to the Harmony CLI before we can accept your contribution [1]. Gave it a spin and ran some configurations, so you can consider this: Tested-by: Folke Gleumes [0] https://pve.proxmox.com/wiki/Perl_Style_Guide [1] https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_C= opyright On Tue, 2024-04-16 at 09:27 +0200, Daniel Krambrock via pve-devel wrote: > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel