From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DC48E6263D for ; Thu, 20 Jan 2022 16:48:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF9B1277FF for ; Thu, 20 Jan 2022 16:48:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 41978277EE for ; Thu, 20 Jan 2022 16:48:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0ED6A46CA1; Thu, 20 Jan 2022 16:48:35 +0100 (CET) Message-ID: Date: Thu, 20 Jan 2022 16:48:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox VE development discussion , Nicholas Sherlock References: <0100017e6f20a655-ab37d914-86d7-4a80-a82e-1293bef516b0-000000@email.amazonses.com> From: Dominik Csapak In-Reply-To: <0100017e6f20a655-ab37d914-86d7-4a80-a82e-1293bef516b0-000000@email.amazonses.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.162 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH v2 qemu-server 0/1] pci: allow override of PCI vendor/device ids X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jan 2022 15:48:36 -0000 On 1/18/22 22:38, Nicholas Sherlock wrote: > In this version, changed proposed x-pci-device-id names to remove x-pci- prefix to shorten configs, and improved Perl code style, thanks to Dominik Csapak > > [PATCH v2 qemu-server] pci: allow override of PCI vendor/device ids > [PATCH v2 pve-manager] ui: pci passthrough: editor for pci-id > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > Thanks, 2 nits left (you could send a v3, or we can fix it up, please write what you prefer) * the commit message should not have lines longer than 70 characters[0] * and the gettext is not optimal, i'd omit the 'Set ' prefix (sorry i did not catch it the first time), so 'Vendor ID' instead of 'Set vendor ID' otherwise: Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak 0: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages