From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7557471800 for ; Mon, 20 Jun 2022 11:17:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 63EAD28276 for ; Mon, 20 Jun 2022 11:16:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4E6C028268 for ; Mon, 20 Jun 2022 11:16:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EECBB43BD1 for ; Mon, 20 Jun 2022 11:11:15 +0200 (CEST) Message-ID: Date: Mon, 20 Jun 2022 11:11:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: Wolfgang Bumiller Cc: pve-devel@lists.proxmox.com References: <20220615140950.2586849-1-m.limbeck@proxmox.com> <20220617084236.aoss7otwx3ee6on7@wobu-vie.proxmox.com> From: Mira Limbeck In-Reply-To: <20220617084236.aoss7otwx3ee6on7@wobu-vie.proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH access-control] fix #4074: increase API OpenID code size limit to 2048 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2022 09:17:08 -0000 On 6/17/22 10:42, Wolfgang Bumiller wrote: > On Wed, Jun 15, 2022 at 04:09:50PM +0200, Mira Limbeck wrote: >> Azure AD seems to have a variable authorization code size, depending on >> the browser state according to one report in bug #4074 [0]. >> >> Sometimes the size is greater than our current limit of 1024, so >> increase it to 2048. > Would there be any downside to just going straight to 4 or 8K here? > I don't think so. I just went with the usual `increase it to handle the current requirements` approach here. If you prefer a higher limit then sure, I'll send a v2 with 4k or 8k. The mentions in the bug tracker/forum post were of code sizes about 1100-1300 in length.