From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D2E6C906B0; Thu, 22 Sep 2022 12:36:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A88EA7935; Thu, 22 Sep 2022 12:35:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Thu, 22 Sep 2022 12:35:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 39C5B444EA; Thu, 22 Sep 2022 12:35:31 +0200 (CEST) Message-ID: Date: Thu, 22 Sep 2022 12:35:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Thunderbird/105.0 To: Proxmox VE development discussion , Matthias Heiserer , pbs-devel@lists.proxmox.com References: <20220721104559.302270-1-m.heiserer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20220721104559.302270-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.928 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.702 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-backup] fix #4165: SMART: add raw field X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2022 10:36:03 -0000 all 3 patches LGTM the only (minor) thing is that the wt patch could have handled the current situation (pve raw+value, pbs normalized+value), e.g by using the field 'convert' or 'calculate' methods of extjs (we could have had a 'real_raw' and 'real_normalized' that uses the values depending on which exist) then we would not need a depends/breaks on the versions (not sure which direction here) if everybody else is ok with these dependencies, consider these patches: Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak