From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A25EE1FF164 for ; Fri, 8 Nov 2024 14:03:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CA26DDBE4; Fri, 8 Nov 2024 14:03:00 +0100 (CET) Message-ID: Date: Fri, 8 Nov 2024 14:02:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Timothy Nicholson References: <20241108125254.147646-1-t.nicholson@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <20241108125254.147646-1-t.nicholson@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH widget-toolkit] fix #5836: ui: translate systemd states in ServiceView X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thanks for giving this a shot! One comment inline On 2024-11-08 13:52, Timothy Nicholson wrote: > With this patch, all systemd states and unit states in the service > view use gettext to be translated. > > Signed-off-by: Timothy Nicholson > --- > As stated in the Bugzilla entry [0]: Up until now, only two > systemd states were translated. This patch changes this so all > systemd states use gettext and are translated. For some of the > states, translations need to be added. > [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5836 > > src/Utils.js | 11 +++++++++++ > src/node/ServiceView.js | 14 ++++++-------- > 2 files changed, 17 insertions(+), 8 deletions(-) > > diff --git a/src/Utils.js b/src/Utils.js > index 7dd034a..23b0db5 100644 > --- a/src/Utils.js > +++ b/src/Utils.js > @@ -305,6 +305,17 @@ utilities: { > return Ext.htmlEncode(username); > }, > > + renderSystemdStatus: function(status) { > + switch (status) { > + case 'masked': > + return gettext('disabled'); > + case 'not-found': > + return gettext('not installed'); > + default: > + return gettext(status); While the gettext function itself will gladly accept a string passed in from a variable, the script extracting translatable strings [1] expects a literal string that will be used as a reference for translations. [1] https://git.proxmox.com/?p=proxmox-i18n.git;a=blob;f=jsgettext.pl;h=7f758fd9e5b3f5f7e0fb0c2ca0f46690df59dd58;hb=HEAD -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel