From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 408DE1FF2CF for ; Thu, 11 Jul 2024 13:31:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E6137322D1; Thu, 11 Jul 2024 13:31:46 +0200 (CEST) Message-ID: Date: Thu, 11 Jul 2024 13:31:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Christoph Heiss References: <20240711095641.369504-1-c.heiss@proxmox.com> From: Aaron Lauterer In-Reply-To: <20240711095641.369504-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer v2 0/3] add check/rename for already-existing ZFS rpool X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" gave it a test on a VM with the GUI installer. consider this series: Tested-By: Aaron Lauterer Reviewed-By: Aaron Lauterer On 2024-07-11 11:56, Christoph Heiss wrote: > Pretty straight forward overall, implements a check for an existing > `rpool` on the system and ask the user whether they would like to rename > it, much in the same way as it works for VGs already. > > Without this, the installer would silently create a second (and thus > conflicting) `rpool` and cause a boot failure after the installation, > since it does not know which pool to import exactly. > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063874.html > > Notable changes v1 -> v2: > * incorporated Aaron suggestions from v1 > * rewrote tests to use a pre-defined input instead > * moved pool renaming to own subroutine > * documented all new subroutines > * split out tests into own patch > > Christoph Heiss (3): > proxmox: add zfs module for retrieving importable zpool info > test: add test cases for new zfs module > low-level: install: check for already-existing `rpool` on install > > Proxmox/Install.pm | 30 +++++++++++ > Proxmox/Makefile | 1 + > Proxmox/Sys/ZFS.pm | 109 ++++++++++++++++++++++++++++++++++++++ > test/Makefile | 7 ++- > test/zfs-get-pool-list.pl | 57 ++++++++++++++++++++ > 5 files changed, 203 insertions(+), 1 deletion(-) > create mode 100644 Proxmox/Sys/ZFS.pm > create mode 100755 test/zfs-get-pool-list.pl > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel