From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DE2391FF163 for <inbox@lore.proxmox.com>; Thu, 19 Dec 2024 13:32:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 242A04B69; Thu, 19 Dec 2024 13:32:32 +0100 (CET) Message-ID: <d44cf54a-b7be-4c31-bb79-1b5941876715@proxmox.com> Date: Thu, 19 Dec 2024 13:32:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Alexander Abraham <a.abraham@proxmox.com> References: <20241217101107.43986-1-a.abraham@proxmox.com> <20241217101107.43986-3-a.abraham@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20241217101107.43986-3-a.abraham@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.102 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.108.153, 185.199.111.153, 185.199.110.153, 185.199.109.153] Subject: Re: [pve-devel] [Typo corrected. 2/2] Split a long sentence and corrected some typos. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> If you send another version of a patch series, please use the "-v <n>, --reroll-count=<n>" option for "git format-patch". As long as you are working on a series, you can "change history" on your local branch. This can be done with "git rebase -i" and "git commit --amend" and (there are also things like "git absorb"), there are plenty tutorials on the web. For the patch at hand, you could fold this change into the previous patch with "--amend" and just send out the corrected patch by itself and... Am 17.12.24 um 11:11 schrieb Alexander Abraham: > --- ...for the corrected patch, put a changelog down here and in the cover letter. By prettying up your local git history, the patches will be easier to review and when applied for real on the shared master branch, the history will be nice to read :) Not related to this series and depends on the situations, just mentioning as a general hint: often one runs into problems during development, and they might then be missing from the "clean" git history. It's often worth mentioning those in commit messages, so they still become a part of history. > local-zfs.adoc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/local-zfs.adoc b/local-zfs.adoc > index bcd02f7..b662233 100644 > --- a/local-zfs.adoc > +++ b/local-zfs.adoc > @@ -627,7 +627,8 @@ You *must reboot* to activate these changes. > SWAP on ZFS > ~~~~~~~~~~~ > > -It is strongly recommended to not use a ZFS volume for a swap partition because this could lead to deadlocks freezing thge affected system and other unpredictable behavior. The OpenZFS documentation, which can be viewed https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux[here], warns against using a ZFS volume for a swap partition. > +It is strongly recommended to not use a ZFS volume for a swap partition because this could lead to deadlocks. These deadlocks could cause the affected system to freeze. > +The OpenZFS documentation, which can be viewed https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux[here], warns about using a ZFS volume for a swap partition. > > [[zfs_encryption]] > Encrypted ZFS Datasets _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel