From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 34AD0E86C for ; Wed, 19 Jul 2023 12:37:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0C7275B69 for ; Wed, 19 Jul 2023 12:37:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Jul 2023 12:37:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5C70B40F5C for ; Wed, 19 Jul 2023 12:37:16 +0200 (CEST) Message-ID: Date: Wed, 19 Jul 2023 12:37:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Wolfgang Bumiller Cc: pve-devel@lists.proxmox.com References: <20230717150051.710464-1-l.wagner@proxmox.com> <20230717150051.710464-25-l.wagner@proxmox.com> <77dqbcz5rofxaky6oyg5xzv4mjzifovpqoswi35ns3pom643yi@wrqqjwonto5s> From: Lukas Wagner In-Reply-To: <77dqbcz5rofxaky6oyg5xzv4mjzifovpqoswi35ns3pom643yi@wrqqjwonto5s> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.102 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v3 proxmox-perl-rs 24/66] add PVE::RS::Notify module X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2023 10:37:17 -0000 On 7/19/23 12:23, Wolfgang Bumiller wrote: >>> + #[export(raw_return)] >>> + fn parse_config( >>> + #[raw] class: Value, >>> + raw_config: &str, >>> + raw_private_config: &str, >> >> I half-suspect that using &[u8] here - since that's what perl *actually* >> gives us if we just read the data out of files without setting the mode >> to 'utf8' or anything - might just fix the emoji issues. >> >> Alternatively, perl would have to actually declare an encoding ;-) > > Though ultimately the alter patches will probably need to do the same > for things where utf-8 matters (at least the comments). #[export(raw_return)] fn parse_config( #[raw] class: Value, raw_config: &[u8], raw_private_config: &[u8], ) -> Result { let raw_config = std::str::from_utf8(raw_config)?; let raw_private_config = std::str::from_utf8(raw_private_config)?; ... This seems to have done the trick. The `update` calls do not seem to need it, it appears to work fine with just this modification. Thanks a lot! -- - Lukas