From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 83A261FF16B for ; Tue, 15 Jul 2025 08:09:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 724E133D62; Tue, 15 Jul 2025 08:10:40 +0200 (CEST) Message-ID: Date: Tue, 15 Jul 2025 08:10:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20250711153404.995040-1-c.ebner@proxmox.com> <84b54b36-41e0-401f-be76-8ea0de180619@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <84b54b36-41e0-401f-be76-8ea0de180619@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC pve-installer v3] fix #6508: auto-installer/post-hook: make iface mac address optional X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 7/14/25 21:27, Thomas Lamprecht wrote: > Am 11.07.25 um 17:34 schrieb Christian Ebner: >> This is a breaking change as it affects the answer file fetch payload, >> the mac address now being optional. The version is therefore bumped. > > Meh, not a big fan - we could rather serialize it to "unknown" and not > bump the schema at all, that would IMO be much more pragmatic for us > and admins relying on this already. > > Internally it could still be an option, that would make use sites of > that information aware about that it might not be usable. > > OTOH, pondering also applying the "just skip" patch for now, while that > might be slightly worse UX, it's a rather unlikely edge case anyway, > especially for servers, where even if such interfaces exists, they are > probably not very likely to be usable after rebooting into the > installed system anyway.. After having looked at the kernel interfaces for this I would argue that skipping these interfaces is the preferred option: They are not of type ethernet anyways as reported by addr_len in sysfs [0], so allowing to set these up as management interface without proper configuration makes not much sense IMO. Further, this would then need proper support for other interface types as well when reading `/sys/class/net//address`. We then still can decide to properly support such interfaces in the future, if the need to setup with them ever arises. Of all 3 patch variants, the skipping seems to be the least invasive for the time being to me. Please let me know how to proceed. [0] https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-net _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel