From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A7AD87339B for ; Thu, 17 Jun 2021 18:00:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8CE491E9D3 for ; Thu, 17 Jun 2021 18:00:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3B5231E9AF for ; Thu, 17 Jun 2021 18:00:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 018D74675B for ; Thu, 17 Jun 2021 18:00:07 +0200 (CEST) Message-ID: Date: Thu, 17 Jun 2021 18:00:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210506121632.8417-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210506121632.8417-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.818 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH-SERIES v5 manager] fix #2745: allow specifying remove parameter for manual backup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 16:00:08 -0000 On 06.05.21 14:16, Fabian Ebner wrote: > Changes from v4: > * dropped already applied patches > * added a few small follow-ups and preparation: > * set loading mask early enough > * switch to two-column layout > * changes for the main patch: > * fix labels and gettext usage > * only show retention settings when prune checkbox is set > > Fabian Ebner (6): > ui: backup window: avoid issuing API call with null/empty parameter > ui: backup window: also set initialDefaults variable in failure case > ui: backup window: set loading mask early enough > ui: backup window: switch to proxmox input panel > ui: backup window: switch to two-column layout > fix #2745: ui: backup window: allow specifying remove parameter for > manual backup > > www/manager6/window/Backup.js | 124 ++++++++++++++++++++++++++++++---- > 1 file changed, 112 insertions(+), 12 deletions(-) > applied series, thanks! Added a label for the retention settings to ensure the user knows that they come from the storage. Also added a log line about what actual retention keep-settings are used, as else I could not be determined in the task-log if they came from a storage or node vzdump.conf.