From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A54821FF2CA for ; Tue, 23 Jul 2024 08:51:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 900753CE20; Tue, 23 Jul 2024 08:52:19 +0200 (CEST) Message-ID: Date: Tue, 23 Jul 2024 08:52:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20240710124300.295817-1-a.lauterer@proxmox.com> Content-Language: en-US From: Aaron Lauterer In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied-series: [PATCH manager 0/2] fix #5570 ceph mds: allow custom MDS IDs from the UI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2024-07-22 18:57, Thomas Lamprecht wrote: > Am 10/07/2024 um 14:42 schrieb Aaron Lauterer: >> The ID for the MDS cannot start with a number [0]. The first patch adds >> a check for this. >> >> The second patch is the actual fix, by reworking the edit window when >> adding new MDS'. >> >> By allowing the users to set the name of the MDS directly, we can catch >> the situation where the hostname starts with a number and let the user >> decide how it should be named. Similar to what they can already do on >> the CLI. >> >> >> Another approach would be to leave the UI as is and catch the situation >> in the backend. If an ID that starts with a number is detected, we could >> prepend it with a default string. >> >> [0] https://docs.ceph.com/en/latest/man/8/ceph-mds/ >> >> Aaron Lauterer (2): >> api: ceph mds: avoid creating MDS when ID starts with number >> fix#5570 ui: ceph: make MDS ID configurable >> >> PVE/API2/Ceph/MDS.pm | 2 ++ >> www/manager6/ceph/ServiceList.js | 21 +++++++++++---------- >> 2 files changed, 13 insertions(+), 10 deletions(-) >> > > > applied with a small s/service_id/serviceID/ style fix squashed into the > UI patch plus added the missing space in the subject between "fix" and the > issue ID, thanks! > > Oh, I also made a follow-up [0] that makes the field required now to avoid > an API error if the user clears the field before submitting.< thx for the fixes! > > [0]: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=d69d4ed8cb276b492a5fe7883f94db777e06d2b2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel