From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D84BC70373 for ; Mon, 13 Jun 2022 14:32:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D643FB0E4 for ; Mon, 13 Jun 2022 14:32:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BF97BB0D4 for ; Mon, 13 Jun 2022 14:32:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9684442DD2 for ; Mon, 13 Jun 2022 14:32:18 +0200 (CEST) Message-ID: Date: Mon, 13 Jun 2022 14:32:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, Dominik Csapak References: <20220602074206.814493-1-d.csapak@proxmox.com> From: Fabian Ebner In-Reply-To: <20220602074206.814493-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.915 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.732 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager/docs v2] handle missed jobs better X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 12:32:19 -0000 Am 02.06.22 um 09:42 schrieb Dominik Csapak: > by adding a config option 'repeat-missed' for jobs that repeats the jobs > on pvescheduler start. new default is 0, which is reverse to current > behaviour (but the more expected one) > > also always skips "missed" jobs when changing from disabled to enabled, > since that is not expected > > changes from v1: > * rename 'skip-missed' to 'repeat-missed' and reverse the default > * always update timestamp on disabled -> enabled > * put the checkbox in advanced items > Just some non-essential nits in the first patch, so: Reviewed-by: Fabian Ebner