From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ECDF171263 for ; Fri, 17 Jun 2022 17:20:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DD82F183D8 for ; Fri, 17 Jun 2022 17:20:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6293A183CD for ; Fri, 17 Jun 2022 17:20:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 34F9142FAE for ; Fri, 17 Jun 2022 17:20:19 +0200 (CEST) Message-ID: Date: Fri, 17 Jun 2022 17:20:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0 Content-Language: en-GB To: Proxmox VE development discussion , Fabian Ebner References: <20220614094732.76236-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220614094732.76236-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [replication.pm] Subject: [pve-devel] applied: [PATCH manager] fix #4111: replication: don't send mail when fail count is zero X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2022 15:20:50 -0000 Am 14/06/2022 um 11:47 schrieb Fabian Ebner: > which can happen when failing to obtain the guest's migration lock. > This led to a lot of mails being sent during migration (timeout for > obtaining lock is only 2 seconds and we run it in a loop). > > One could argue that obtaining the lock should increase the fail > count, but without the lock, the job state should not be touched and > even the first three mails upon migration could be considered spam. > > Fixes: e6b8af20 ("replication: sent always mail for first three tries and move helper") > Signed-off-by: Fabian Ebner > --- > PVE/API2/Replication.pm | 4 ++++ > 1 file changed, 4 insertions(+) > > applied, thanks!