From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 67C801FF145 for ; Thu, 22 Jan 2026 16:31:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 881481A906; Thu, 22 Jan 2026 16:31:52 +0100 (CET) Message-ID: Date: Thu, 22 Jan 2026 16:31:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Dominik Csapak References: <20251212074419.275374-1-d.csapak@proxmox.com> <20251212074419.275374-2-d.csapak@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251212074419.275374-2-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769095850410 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2 2/2] ui: resource tree: only fire 'refresh' event when something changed X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 12.12.25 um 08:44 schrieb Dominik Csapak: > to optimize the rendering to the dom, only fire the 'refresh' event of > the store at the end of the updateTree method when either: > > * an element changed it's relevant data > * something moved > * a new element was inserted > * an element was removed > > We also need to refresh the store when the UI options are reloaded, so > the tags get the correct color. > > Signed-off-by: Dominik Csapak > --- > no changes in v2 > > www/manager6/tree/ResourceTree.js | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js > index b0e094f1..8612269b 100644 > --- a/www/manager6/tree/ResourceTree.js > +++ b/www/manager6/tree/ResourceTree.js > @@ -354,6 +354,7 @@ Ext.define('PVE.tree.ResourceTree', { > let updateTree = function () { > store.suspendEvents(); > > + let any_changed = false; existing style in this module is already rather mixed, so really not a big style issue, but would be still nice to prefer camelCase as per our [JS style guide]. Also here, would probably fixed that just up, but due to replying to patch 1/2 anyway I figured it doesn't hurt to notice this nit. JS style guide: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Casing > let rootnode; > if (firstUpdate) { > rootnode = Ext.create('PVETree', { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel