From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8057F63E3D for ; Thu, 27 Jan 2022 15:22:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E97D23EDA for ; Thu, 27 Jan 2022 15:21:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 39BC123ECB for ; Thu, 27 Jan 2022 15:21:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0D6ED46CFD; Thu, 27 Jan 2022 15:21:42 +0100 (CET) Message-ID: Date: Thu, 27 Jan 2022 15:21:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox VE development discussion , Nicholas Sherlock References: <0100017e6f20b0f4-8e2dc40b-0274-4e06-97bc-a57c6e5da0d2-000000@email.amazonses.com> From: Thomas Lamprecht In-Reply-To: <0100017e6f20b0f4-8e2dc40b-0274-4e06-97bc-a57c6e5da0d2-000000@email.amazonses.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v2 pve-manager] ui: pci passthrough: editor for pci-id overrides X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 14:22:13 -0000 On 18.01.22 22:38, Nicholas Sherlock wrote: > From: Nicholas Sherlock > > Signed-off-by: Nicholas Sherlock > --- > www/manager6/Toolkit.js | 2 ++ > www/manager6/qemu/PCIEdit.js | 36 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+) > > applied, thanks! I adapted the labels in a follow up, but also tried to clarify where the value comes from if empty with a "From Device" empty-text. Further clarifications would be probably good to have in the documentation, would you be willing to write some short paragraph for the respective section in pve-doc's qm-pci-passthrough.adoc? No pressure though, Dominik offered to check that out too if you don't get around or the like. cheers, Thomas