From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 34EED9924F for ; Tue, 10 Oct 2023 15:06:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16FE5331C9 for ; Tue, 10 Oct 2023 15:06:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 10 Oct 2023 15:06:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E3D6F4489A for ; Tue, 10 Oct 2023 15:06:37 +0200 (CEST) Message-ID: Date: Tue, 10 Oct 2023 15:06:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20230821100651.1167084-1-a.lauterer@proxmox.com> From: Fiona Ebner In-Reply-To: <20230821100651.1167084-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.584 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.339 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2023 13:06:40 -0000 Am 21.08.23 um 12:06 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > www/manager6/storage/DirEdit.js | 4 ++++ > www/manager6/storage/LVMEdit.js | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js > index 7e9ec44d..8469a7c3 100644 > --- a/www/manager6/storage/DirEdit.js > +++ b/www/manager6/storage/DirEdit.js > @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', { > name: 'shared', > uncheckedValue: 0, > fieldLabel: gettext('Shared'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'), > + } eslint complains about missing trailing comma > }, > ]; > > diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js > index 75c7bdb8..0d9efd21 100644 > --- a/www/manager6/storage/LVMEdit.js > +++ b/www/manager6/storage/LVMEdit.js > @@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', { > name: 'shared', > uncheckedValue: 0, > fieldLabel: gettext('Shared'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'), > + } eslint complains about missing trailing comma > }, > ], > }); With those fixed: Reviewed-by: Fiona Ebner