From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <l.wagner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BA6E4E90B for <pve-devel@lists.proxmox.com>; Wed, 19 Jul 2023 13:51:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D53A6543 for <pve-devel@lists.proxmox.com>; Wed, 19 Jul 2023 13:51:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 19 Jul 2023 13:51:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EF46640FC5 for <pve-devel@lists.proxmox.com>; Wed, 19 Jul 2023 13:51:33 +0200 (CEST) Message-ID: <d19491e3-0b83-46dc-ab4a-ebb393d62ae5@proxmox.com> Date: Wed, 19 Jul 2023 13:51:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Wolfgang Bumiller <w.bumiller@proxmox.com> Cc: pve-devel@lists.proxmox.com References: <20230717150051.710464-1-l.wagner@proxmox.com> <20230717150051.710464-7-l.wagner@proxmox.com> <xytbbx76nkkk4efqai6upcobzhjazpatdt3wbhapkcdi7zg32u@p54ub4s63y5x> From: Lukas Wagner <l.wagner@proxmox.com> In-Reply-To: <xytbbx76nkkk4efqai6upcobzhjazpatdt3wbhapkcdi7zg32u@p54ub4s63y5x> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.101 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v3 proxmox 06/66] notify: api: add API for sendmail endpoints X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 19 Jul 2023 11:51:34 -0000 On 7/18/23 14:36, Wolfgang Bumiller wrote: >> + >> +/// Get sendmail endpoint with given `name`. >> +/// >> +/// The caller is responsible for any needed permission checks. >> +/// Returns the endpoint or an `ApiError` if the endpoint was not found. >> +pub fn get_endpoint(config: &Config, name: &str) -> Result<SendmailConfig, ApiError> { >> + config >> + .config >> + .lookup(SENDMAIL_TYPENAME, name) >> + .map_err(|_| ApiError::not_found(format!("endpoint '{name}' not found"), None)) > > ^ Technically `.lookup()` could have found the name but as a wrong type. > It might make sense to not use `.lookup()` in this case. > `.lookup()` should be fine here from what I can tell. I actually want a `not found` if there is another endpoint with that name but a different type, because the endpoints have a distinct typed path prefix in the REST API: GET endpoints/sendmail/<name> GET endpoints/gotify/<name> -- - Lukas