From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 602E01FF15E for ; Fri, 18 Oct 2024 09:42:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5B9C71C973; Fri, 18 Oct 2024 09:42:30 +0200 (CEST) Message-ID: Date: Fri, 18 Oct 2024 09:42:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Lukas Wagner To: Proxmox VE development discussion , Daniel Kral References: <20241016164711.934544-1-d.kral@proxmox.com> <20241016164711.934544-3-d.kral@proxmox.com> Content-Language: de-AT, en-US In-Reply-To: <20241016164711.934544-3-d.kral@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 2/5] ui: vm: factor out async I/O type selector X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Hello, one comment inline. Skimmed over the code to spot style issues, correctness was not really checked. On 2024-10-16 18:47, Daniel Kral wrote: > Factors out the combo box used for the Async I/O combo box selector, > which is used in the Disk Edit modal window in the VM "Hardware" tab and > the "Disks" tab in the Create Wizard, to reuse it in a future commit. > > Signed-off-by: Daniel Kral > --- > www/manager6/Makefile | 1 + > www/manager6/form/AsyncIOTypeSelector.js | 10 ++++++++++ > www/manager6/qemu/HDEdit.js | 10 ++-------- > 3 files changed, 13 insertions(+), 8 deletions(-) > create mode 100644 www/manager6/form/AsyncIOTypeSelector.js > > diff --git a/www/manager6/Makefile b/www/manager6/Makefile > index 2c3a822b..74a61aa8 100644 > --- a/www/manager6/Makefile > +++ b/www/manager6/Makefile > @@ -21,6 +21,7 @@ JSSRC= \ > form/ACMEAccountSelector.js \ > form/ACMEPluginSelector.js \ > form/AgentFeatureSelector.js \ > + form/AsyncIOTypeSelector.js \ > form/BackupCompressionSelector.js \ > form/BackupModeSelector.js \ > form/BandwidthSelector.js \ > diff --git a/www/manager6/form/AsyncIOTypeSelector.js b/www/manager6/form/AsyncIOTypeSelector.js > new file mode 100644 > index 00000000..83fb40b5 > --- /dev/null > +++ b/www/manager6/form/AsyncIOTypeSelector.js > @@ -0,0 +1,10 @@ > +Ext.define('PVE.form.AsyncIOTypeSelector', { > + extend: 'Proxmox.form.KVComboBox', > + alias: ['widget.AsyncIOTypeSelector'], Usually we use a prefix `pve` (for components defined in pve-manager) or `pmx` (for components defined in proxmox-widget-toolkit`) prefix, so this should be `widget.pveAsyncIoTypeSelector` > + comboItems: [ > + ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'], > + ['io_uring', 'io_uring'], > + ['native', 'native'], > + ['threads', 'threads'], > + ], > +}); > diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js > index b78647ec..37215361 100644 > --- a/www/manager6/qemu/HDEdit.js > +++ b/www/manager6/qemu/HDEdit.js > @@ -306,17 +306,11 @@ Ext.define('PVE.qemu.HDInputPanel', { > name: 'noreplicate', > }, > { > - xtype: 'proxmoxKVComboBox', > + xtype: 'AsyncIOTypeSelector', > name: 'aio', > + value: '__default__', > fieldLabel: gettext('Async IO'), > allowBlank: false, > - value: '__default__', > - comboItems: [ > - ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'], > - ['io_uring', 'io_uring'], > - ['native', 'native'], > - ['threads', 'threads'], > - ], > }, > ); > -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel