From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E48A31FF16B for ; Thu, 28 Nov 2024 15:56:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EDEA79198; Thu, 28 Nov 2024 15:56:49 +0100 (CET) Message-ID: Date: Thu, 28 Nov 2024 15:56:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Filip Schauer References: <20241125130908.22076-1-f.schauer@proxmox.com> Content-Language: en-US From: Daniel Kral In-Reply-To: <20241125130908.22076-1-f.schauer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container] fix #5907: ignore conflicting mount options for read-only mounts X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11/25/24 14:09, Filip Schauer wrote: > When mounting volumes as read-only, certain mount options like > "discard", "lazytime", and "noatime" are either ignored or can cause the > mount to fail. For example, attempting to mount with "-t zfs" and > "-o ro,discard" leads to an error: filesystem cannot be mounted due to > invalid option 'discard'. > > This commit ensures that only valid mount options, such as "nodev", > "noexec", and "nosuid", are applied to read-only mounts, avoiding > potential mount failures. > > Signed-off-by: Filip Schauer I could reproduce the issue when backing up a container with at least one root disk or mountpoint, which has at least the mount option "discard" applied, and backing it up to a PBS instance (to stay close to the bug report I used v3.2.10-1 for this), while all images were stored on a ZFS pool. After applying the patch, the container could be backed up to the same PBS instance without any trouble. Reviewed-by: Daniel Kral Tested-by: Daniel Kral _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel