From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AC6421FF140 for ; Fri, 27 Mar 2026 11:05:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EAE482983; Fri, 27 Mar 2026 11:06:03 +0100 (CET) Message-ID: Date: Fri, 27 Mar 2026 11:05:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network 01/13] controller: bgp: evpn: adapt to new match / set frr config syntax To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260325094142.174364-1-s.hanreich@proxmox.com> <20260325094142.174364-16-s.hanreich@proxmox.com> <8cc562e2-87c9-41f5-bfb4-2e33154d57f7@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <8cc562e2-87c9-41f5-bfb4-2e33154d57f7@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.712 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DBJM4Y53WSGKBTP5G3M2DORPD3UVJ5XT X-Message-ID-Hash: DBJM4Y53WSGKBTP5G3M2DORPD3UVJ5XT X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/26/26 4:19 PM, Hannes Laimer wrote: > On 2026-03-25 10:41, Stefan Hanreich wrote: >> proxmox-frr has changed the representation of match / set statements >> in its structs. It has changed to generic key / value fields, where >> the keys specify the literal name of the key in the FRR configuration. >> >> Adapt the controllers to use the new fields so the configuration gets >> generated properly. >> >> Signed-off-by: Stefan Hanreich >> --- > > [..] > >> diff --git a/src/PVE/Network/SDN/Controllers/BgpPlugin.pm b/src/PVE/Network/SDN/Controllers/BgpPlugin.pm >> index 8891541..d54c9ec 100644 >> --- a/src/PVE/Network/SDN/Controllers/BgpPlugin.pm >> +++ b/src/PVE/Network/SDN/Controllers/BgpPlugin.pm >> @@ -136,13 +136,12 @@ sub generate_frr_config { >> $config->{frr}->{protocol_routemaps}->{bgp}->{v4} = "correct_src"; >> >> my $routemap_config = { >> - protocol_type => 'ip', >> - match_type => 'address', >> - value => { list_type => 'prefixlist', list_name => 'loopbacks_ips' }, >> + key => 'ip address prefix-list', >> + value => 'loopbacks_ips', > > given that > ``` > + if ($id =~ m/^(only_default|only_default_v6|loopback_ips|)$/) { > + return undef if $noerr; > + die "prefix list ID '$id' is currently reserved and cannot > be used\n"; > + } > ``` > is added in the next patch(02/13 pve-network), it looks like a `s` > slipped onto the end of `loopback` here :) it's actually the other way around - the pre-existing name is indeed loopbacks_ips - so it needs to be fixed in the ID validation... see https://git.proxmox.com/?p=pve-network.git;a=blob;f=src/PVE/Network/SDN/Controllers/BgpPlugin.pm;h=447ebf1ba74492898b7692988e6d5fb230f55552;hb=HEAD#l128