From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 25DBB1FF187 for ; Mon, 11 Aug 2025 11:24:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 482C7317A0; Mon, 11 Aug 2025 11:26:18 +0200 (CEST) Message-ID: Date: Mon, 11 Aug 2025 11:25:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: pve-devel@lists.proxmox.com References: <20250808150814.110051-1-h.laimer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250808150814.110051-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754904316659 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-cluster v2] fix #6615: rrd: only return populated entries X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Hi, please correct me if I'm wrong, but wouldn't this change drastically change the graphs on the web ui ? (did not test it though) when e.g. a storage is offline, it will have intermediary empty values? so instead of having [ { time: 1, value: 1}, { time: 2 }, { time: 3, value: 2} ] where we get a whole between 1 and 3, but with this patch we'd get [ { time: 1, value: 1}, { time: 3, value: 2}, ] which would draw a line between 1 and 3 i guess? On 8/8/25 17:07, Hannes Laimer wrote: > RRD fetch can include the latest bucket before metrics are flushed, > resulting in entries with only a timestamp. > > This now only returns entries with at least one value. > > Signed-off-by: Hannes Laimer > --- > since v1, thanks @Fabian: > - just check count of keys in entry instead of keeping track of when > something is added > > src/PVE/RRD.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/RRD.pm b/src/PVE/RRD.pm > index 8fe1927..1813cdb 100644 > --- a/src/PVE/RRD.pm > +++ b/src/PVE/RRD.pm > @@ -78,7 +78,8 @@ sub create_rrd_data { > # maybe make this configurable? > } > } > - push @$res, $entry; > + # 'time' + at least one metric > + push @$res, $entry if (scalar keys %$entry) > 1; > } > > return $res; _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel