From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 2F1391FF13E
	for <inbox@lore.proxmox.com>; Fri, 06 Mar 2026 13:37:17 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 56B37310C7;
	Fri,  6 Mar 2026 13:38:22 +0100 (CET)
Date: Fri, 6 Mar 2026 13:37:48 +0100
From: Gabriel Goller <g.goller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [PATCH pve-manager v3 1/1] sdn: add dry-run diff view for sdn
 apply
Message-ID: <csvzgbjuabmwvoiorsiqwxlpuviiatnoy52fwe4dblt6u2lpri@hz6zhac3ycs4>
Mail-Followup-To: Stefan Hanreich <s.hanreich@proxmox.com>,
	pve-devel@lists.proxmox.com
References: <20260305100331.80741-1-g.goller@proxmox.com>
 <20260305100331.80741-20-g.goller@proxmox.com>
 <5b84e2db-7855-4bca-9c61-dc481e5a6f40@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5b84e2db-7855-4bca-9c61-dc481e5a6f40@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1772800640250
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -1.055 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_MSPIKE_H2       0.001 Average reputation (+2)
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.617 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.892 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.622 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: QQYYLAVQYIRVMCG2WWXWWCEM5V4KI22G
X-Message-ID-Hash: QQYYLAVQYIRVMCG2WWXWWCEM5V4KI22G
X-MailFrom: g.goller@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 06.03.2026 10:24, Stefan Hanreich wrote:
> still looks a bit barebones imo, but at least its monospaced now ;)
> Maybe we could make the '{FRR,Interfaces} Config' headings rows, instead
> of taking up a whole column with lots of unused whitespace.
> I think it should also show a nicer message when there are no changes -
> stating explicitly that nothing changed - instead of just an empty panel.
> 
> Not a big blocker, since we can always improve it in a follow-up patch.

Done, will send a v4 soon!