From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DD1BD1FF185 for ; Mon, 7 Jul 2025 16:43:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 672993590C; Mon, 7 Jul 2025 16:43:42 +0200 (CEST) Date: Mon, 7 Jul 2025 16:43:06 +0200 From: Gabriel Goller To: Wolfgang Bumiller Message-ID: Mail-Followup-To: Wolfgang Bumiller , pve-devel@lists.proxmox.com References: <20250702145101.894299-1-g.goller@proxmox.com> <20250702145101.894299-12-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-ve-rs v4 05/22] frr: add common frr types X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 07.07.2025 13:18, Wolfgang Bumiller wrote: >On Wed, Jul 02, 2025 at 04:49:56PM +0200, Gabriel Goller wrote: >> [snip] >> +impl FromStr for FrrWord { >> + type Err = FrrWordError; >> + >> + fn from_str(s: &str) -> Result { >> + FrrWord::new(s.to_string()) > >^ Let's try to avoid allocating before error-checking. We could move the >check out of `new()` into a helper, call that, then just build >`Self(s.to_string())`. Changed new into: pub fn new + Into>(name: T) and called new in the FromStr impl. Hope that's alright. >> + } >> +} >> + >> +impl Display for FrrWord { >> + fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { >> + self.0.fmt(f) >> + } >> +} >> + >> +impl AsRef for FrrWord { >> + fn as_ref(&self) -> &str { >> + &self.0 >> + } >> +} >> + >> +#[derive(Error, Debug)] >> +pub enum CommonInterfaceNameError { >> + #[error("interface name too long")] >> + TooLong, >> +} >> + >> +/// Name of a interface, which is common between all protocols. >> +/// >> +/// FRR itself doesn't enforce any limits, but the kernel does. Linux only allows interface names >> +/// to be a maximum of 16 bytes. This is enforced by this struct. >> +#[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize, Hash, PartialOrd, Ord)] >> +pub struct CommonInterfaceName(String); >> + >> +impl FromStr for CommonInterfaceName { > >^ `FromStr` is not in the prelude. >Via prelude this only provides `.parse()`, but we don't really "parse >it". >IMO this could also be a `new()`, and have `TryFrom` and `TryFrom<&str>`. >We can make `fn new + Into>(T)` to be able to >run the check before any potential allocation... Good point. >> + type Err = CommonInterfaceNameError; >> + >> + fn from_str(s: &str) -> Result { >> + if s.len() <= 15 { >> + Ok(Self(s.to_owned())) >> + } else { >> + Err(CommonInterfaceNameError::TooLong) >> + } >> + } >> +} >> + >> +impl Display for CommonInterfaceName { >> + fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { >> + self.0.fmt(f) >> + } >> +} Thanks for the review! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel