From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E5EA21FF15C for ; Wed, 21 Aug 2024 11:35:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7AE12158FA; Wed, 21 Aug 2024 11:35:22 +0200 (CEST) Date: Wed, 21 Aug 2024 11:35:19 +0200 From: Christoph Heiss To: Alexander Zeidler Message-ID: References: <20240809115145.1005005-1-c.heiss@proxmox.com> <20240809115145.1005005-2-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm] Subject: Re: [pve-devel] [PATCH installer 1/2] low level: config: filter out kernel cmdline on word boundaries X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thanks for the review! On Wed, Aug 14, 2024 at 12:51:27PM GMT, Alexander Zeidler wrote: > On Fri Aug 9, 2024 at 1:51 PM CEST, Christoph Heiss wrote: > > [..] > > diff --git a/Proxmox/Install/Config.pm b/Proxmox/Install/Config.pm > > index ae70093..6b064b1 100644 > > --- a/Proxmox/Install/Config.pm > > +++ b/Proxmox/Install/Config.pm > > @@ -43,8 +43,8 @@ my sub parse_kernel_cmdline { > > } > > } > > > > - $cmdline =~ s/(?:BOOT_IMAGE|root|ramdisk_size|splash|vga)=\S+\s?//gi; > > - $cmdline =~ s/ro|rw|quiet|proxdebug|proxtui|nomodeset//gi; > > + $cmdline =~ s/\b(?:BOOT_IMAGE|root|ramdisk_size|splash|vga)=\S+\s?\b//gi; > > > + $cmdline =~ s/\bro|rw|quiet|proxdebug|proxtui|nomodeset\b//gi; > There are parentheses missing next to \b . > > The current implementation seems not to be strict enough when dealing > with variables. For example, the variable regex would not match > something like 'apic=quiet', but then the second regex matches wrongly > 'quiet'. Good catch! There are indeed some parentheses missing here :^) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel