From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7B494BA533 for ; Thu, 14 Dec 2023 10:35:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5571714C46 for ; Thu, 14 Dec 2023 10:34:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 14 Dec 2023 10:34:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1ED1B47547 for ; Thu, 14 Dec 2023 10:34:58 +0100 (CET) Message-ID: Date: Thu, 14 Dec 2023 10:34:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Stefan Hanreich References: <20231213153538.358434-1-s.hanreich@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve-manager] postinst: Filter RADOS block devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2023 09:35:29 -0000 Already discussed with Stefan off-list yesterday, posting here for the record: There is one problem when upgrading from < 8.1.4 with a custom LVM config where global_filter spans multiple lines, e.g.: devices { # added by pve-manager to avoid scanning ZFS zvols global_filter=["r|/dev/zd.*|", "r|/dev/foobar|"] } With the patch, this is rewritten but only the first line is commented out: devices { # added by pve-manager to avoid scanning ZFS zvols # global_filter=["r|/dev/zd.*|", "r|/dev/foobar|"] } devices { # added by pve-manager to avoid scanning ZFS zvols and RADOS block devices global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"] } And LVM doesn't like this: # lvs Parse error at byte 111808 (line 2453): unexpected token Failed to load config file /etc/lvm/lvm.conf Not sure how we could extend the global_filter in a reliable way if it is customized ... worst case, it might be an option to only rewrite the LVM config if it is unchanged (plus our ZFS zvol addition), and leave custom configs alone (and add a hint in the upgrade guide)?