From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id D475C1FF189
	for <inbox@lore.proxmox.com>; Fri,  4 Apr 2025 13:38:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id DAF4C1D33D;
	Fri,  4 Apr 2025 13:38:02 +0200 (CEST)
Date: Fri, 4 Apr 2025 13:37:59 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Message-ID: <ce5e7oau6kuxtvuk4fkexgxoigukfvnekqak6ljrrhm5ya272l@lpizedm7xcdd>
References: <20250311132733.820837-1-c.heiss@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250311132733.820837-1-c.heiss@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.081 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH installer] proxmox-chroot: replace
 nix::(u)mount calls with external (u)mount
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: pve-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Tue, Mar 11, 2025 at 02:27:29PM +0100, Christoph Heiss wrote:
> Comes with a reduction of 52 -> 40 in terms of crate dependencies for
> proxmox-chroot, 198 -> 192 for a full workspace build.
> 
> Currently, this is done inconsistently anyway, i.e. there are calls to
> the external mount(8) as well as mount(2) and umount(2) via `nix`.

This makes sense in general. The `mount(2)` syscall is very raw and requires
knowledge of how a file system is to be mounted while additionally
adding a lot more features (especially when the new mount api is used
instead). The `mount(1)` call on the other hand calls out to various
file system specific helpers which provide a more user friendly
interface for various things. (Eg. you *can* definitely use `mount(2)` to
mount a ZFS, but you'd need to know the internals of how that works, and
it may change with zfs versions I think...)

Mounting is complicated in some cases ;-)

Unmounting on the other hand is rather simple and really just needs a
path... (the only sad part there is that there is no
path-file-descriptor based version)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel