From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 65F766DE90 for ; Mon, 28 Mar 2022 11:43:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5A4BF24398 for ; Mon, 28 Mar 2022 11:43:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D63532438D for ; Mon, 28 Mar 2022 11:43:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A3A58425F0 for ; Mon, 28 Mar 2022 11:43:06 +0200 (CEST) Message-ID: Date: Mon, 28 Mar 2022 11:43:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20220324113331.681971-1-m.heiserer@proxmox.com> <71df5a51-c6d8-55d0-af6f-7815f1c77ec8@proxmox.com> From: Matthias Heiserer In-Reply-To: <71df5a51-c6d8-55d0-af6f-7815f1c77ec8@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit 1/2] Utils: add calculate max button width hack X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 09:43:07 -0000 On 25.03.2022 09:47, Thomas Lamprecht wrote: > On 24.03.22 12:33, Matthias Heiserer wrote: >> The same code is used once in widget toolkit and twice in PVE already, >> so it makes sense to add it as a separate function. >> > > FWIW, there'd be also the possibility of adding a new button class, derived > from proxmoxButton, that would be a bit more boilerplate but also avoid having a > rather specific helper in the general utils class and avoid coupling from property > existance/behavior over such "code distance". Maybe we could also move some more > common "AltButton" behavior in there though (did not checked too closely). > What do you think? > Not a big fan tbh, as would mean it can't be used with an Ext.button. Id prefer putting the helper in the Button file, but that doesn't seem to be possible with Extjs. > Also, it could be great to avoid the "text at call time is the initial text" > assumption in the width calculation, e.g., > > let otherText = btn.text === btn.defaultText ? btn.altText : btn.defaultText; > > currently unnecessary, but would make it more robust and to easy to not do, IMO. good call