From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 827C01FF165 for ; Thu, 31 Jul 2025 16:08:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 116AC3D3E4; Thu, 31 Jul 2025 16:09:38 +0200 (CEST) Message-ID: Date: Thu, 31 Jul 2025 16:09:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Shannon Sterz , Proxmox VE development discussion References: <20250731135147.138187-1-f.weber@proxmox.com> <175397021624.1346496.13388080887498120500.b4-ty@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753970959822 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH manager] ui: RRD graphs: display PSI as percent X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 31/07/2025 16:08, Shannon Sterz wrote: > On Thu Jul 31, 2025 at 3:56 PM CEST, Thomas Lamprecht wrote: >> On Thu, 31 Jul 2025 15:51:42 +0200, Friedrich Weber wrote: >>> Pressure stall information are actually in percent. This is not >>> mentioned explicitly in the documentation, but e.g. in the kernel >>> source [1]: >>> >>>> The percentage of wall clock time spent in those compound stall >>>> states gives pressure numbers between 0 and 100 for each resource, >>>> where the SOME percentage indicates workload slowdowns and the FULL >>>> percentage indicates reduced CPU utilization: >>>> >>>> %SOME = time(SOME) / period >>>> %FULL = time(FULL) / period >>> >>> [...] >> >> This was a bit strange for me, I seemingly ingrained some wrong knownledge when >> getting first exposed to PSI when that was a new thing back in 2019 or so, >> either the docs where worded a bit differently or I just read a bit to much >> into the wording (more likely), anyhow thanks for clarifying this, one thing >> that I'm still wondering is this then percent for real (i.e. * 100 already) or >> a ratio? Or would we need to do *= 100 scaling? >> >> Anyway, as this restores the status quo with rationale it's already an >> improvement as is, so: Applied, thanks! > > if i remember correctly and read the kernel documentation correctly, > this is proper percent (%) [1]. so no additional multiplying necessary. > >> The ratios (in %) are tracked as recent trends over ten, sixty, and >> three hundred second windows, which gives insight into short term >> events as well as medium and long term trends. Good catch! So the docs *do* mention it, but of course I only grepped for "percent" ... :) > > also did i quick check here on my machine (by compiling pbs): > >> ==> /proc/pressure/cpu <== >> some avg10=10.63 avg60=3.66 avg300=0.87 total=54165853 > > so the `avg10=10.63` should be percent. > > [1]: https://www.kernel.org/doc/html/latest/accounting/psi.html > >> >> [1/1] ui: RRD graphs: display PSI as percent >> commit: 2753e104a1e6effa4a0ae995f13636a02f3557af >> >> >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel