From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 17590A2201 for ; Fri, 16 Jun 2023 16:13:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E77D534564 for ; Fri, 16 Jun 2023 16:12:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Jun 2023 16:12:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 41F2145B6A for ; Fri, 16 Jun 2023 16:12:54 +0200 (CEST) Message-ID: Date: Fri, 16 Jun 2023 16:12:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20230616095708.1323621-1-a.lauterer@proxmox.com> From: Fiona Ebner In-Reply-To: <20230616095708.1323621-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.098 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v4 qemu-server, container, docs 0/12] migration: don't scan all storages, fail on aliases X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jun 2023 14:13:25 -0000 Am 16.06.23 um 11:56 schrieb Aaron Lauterer: > Oh boy did this version explode in number of commits. Made it very easy to already apply a patch and review the others and catch the few remaining issues :) As already discussed off-list, switching the attribute in foreach_volid from referenced_in_config to is_attached and not have the unused disks be part of is_attached might be best. Because whether the disk is attached or not is what migration, being the only user of this attribute, cares about. Apart from the 'ref' handling, there's also > my $msg = "can't migrate local cdrom drive"; > if (defined($snaprefs) && !$attr->{referenced_in_config}) { > my $snapnames = join(', ', sort keys %$snaprefs); > $msg .= " (referenced in snapshot - $snapnames)"; > } but that can also just s/referenced_in_config/is_attached/ Consider patches 7/12 until 12/12: Reviewed-by: Fiona Ebner