From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6FE2A69C45 for ; Mon, 7 Dec 2020 11:50:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34E3F2359A for ; Mon, 7 Dec 2020 11:50:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BEE572358D for ; Mon, 7 Dec 2020 11:50:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 853B344E46 for ; Mon, 7 Dec 2020 11:50:15 +0100 (CET) To: Proxmox VE development discussion , Stoiko Ivanov References: <20201204175629.30116-1-s.ivanov@proxmox.com> <20201204175629.30116-5-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Mon, 7 Dec 2020 11:50:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <20201204175629.30116-5-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.070 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH http-server v2 4/5] add debug log for problems during accept X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 10:50:46 -0000 On 04.12.20 18:56, Stoiko Ivanov wrote: > Signed-off-by: Stoiko Ivanov > --- > PVE/APIServer/AnyEvent.pm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm > index a679006..0165264 100644 > --- a/PVE/APIServer/AnyEvent.pm > +++ b/PVE/APIServer/AnyEvent.pm > @@ -1547,6 +1547,7 @@ sub check_host_access { > foreach my $t (@{$self->{allow_from}}) { > if ($t->overlaps($cip)) { > $match_allow = 1; > + $self->dprint("client IP allowed: ". $t->prefix()); > last; > } > } > @@ -1555,6 +1556,7 @@ sub check_host_access { > if ($self->{deny_from}) { > foreach my $t (@{$self->{deny_from}}) { > if ($t->overlaps($cip)) { > + $self->dprint("client IP denied: ". $t->prefix()); > $match_deny = 1; > last; > } > @@ -1591,6 +1593,7 @@ sub accept_connections { > my ($pfamily, $pport, $phost) = PVE::Tools::unpack_sockaddr_in46($sin); > ($reqstate->{peer_port}, $reqstate->{peer_host}) = ($pport, Socket::inet_ntop($pfamily, $phost)); > } else { > + $self->dprint("getpeername failed: $!"); > shutdown($clientfh, 1); > next; > } > @@ -1638,6 +1641,7 @@ sub accept_connections { > > if (my $err = $@) { > syslog('err', $err); > + self->dprint("connection accept error: $err"); this cannot work, missing the dollar signe: `self` vs. `$self` > shutdown($clientfh, 1) if $early_err || $hdl_err; > if ($hdl_err) { > if ($self->{conn_count} <= 0) { >