From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 14AD01FF0AF for ; Fri, 20 Nov 2026 15:53:25 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4ADBE217A4; Fri, 20 Nov 2026 15:53:23 +0100 (CET) Message-ID: Date: Fri, 20 Nov 2026 15:53:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager/qemu-server 00/15] check the target node's CPU before live migrating a VM To: "crandler@crandland.de" References: <38B8F285-72BD-CA4C-AC77-1FB069EF64DE@hxcore.ol> Content-Language: en-US From: Jonas Theisen In-Reply-To: <38B8F285-72BD-CA4C-AC77-1FB069EF64DE@hxcore.ol> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795186399421 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.081 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LHLVHZ4PIGKYNHFNOQ5NTSEVQP2V4UTY X-Message-ID-Hash: LHLVHZ4PIGKYNHFNOQ5NTSEVQP2V4UTY X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: "pve-devel@lists.proxmox.com" X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thank you for the feedback! Comments inline: On 11/20/26 01:23, crandler@crandland.de wrote: > > > 1. Built-in models are not covered. A VM with 'x86-64-v3' that is live >  migrated to a node without AVX2 still fails only when QEMU starts on >  the target ("QEMU exited with code 1"). The target builds the CPU >  again from the config, but the model flags are the same, and >  'enforce' is set for all models except 'host'. Since the x86-64-v* >  flags show up explicitly in the running QEMU CPU, the flag part of >  the 'kept-cpu-flags' check should work for them as well. The >  migration dialog would then mark such a node as incompatible, and >  'migrateall' would skip these VMs. Completely correct and an overlook on my end. I have added / extended the appropriate check and will include that in v2. Thanks for noticing! > > 2. HA node selection. As far as I can see, the checks also apply to >  migrations started by the HA stack, which is great. The HA manager >  does not know about them when it picks a target, though (maintenance >  mode, auto-rebalance). If it picks a node that cannot run the VM's >  CPU, the migration is refused and the service goes back to 'started' >  on the source without the failure being recorded, so a later round >  can pick the same node again. #8059 describes this for auto-rebalance >  (failed migrations are retried, candidates are not checked for >  migratability). Would it make sense to let the CRM filter its >  candidate nodes with the same check, or should I open a separate bug >  for that? I think this could be covered in the bug you already mentioned. I included a pointer to it in the v2 cover letter but maybe a small comment on the existing bug could help clarify the interconnect of both issues. > > Thanks, > Sven >